Skip to content

fix: add workflow security configuration #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

fix: add workflow security configuration #471

merged 2 commits into from
Apr 14, 2025

Conversation

@tekenstam
Copy link
Member

@tekenstam tekenstam commented Apr 14, 2025 •
edited
Loading

Add recommended workflow permissions configuration. Also add some image labels.

What type of PR is this?

  • Bug fix (non-breaking change which fixes an issue)
  • Feature/Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Dependency upgrade

Description

Related issue(s)

High-level overview of changes

Testing performed

Checklist

  • I've read the CONTRIBUTING doc
  • I've added/updated tests that prove my fix is effective or that my feature works
  • I've added necessary documentation (if appropriate)
  • I've run make test locally and all tests pass
  • I've signed-off my commits with git commit -s for DCO verification
  • I've updated any relevant documentation
  • Code follows the style guidelines of this project

Additional information

@tekenstam tekenstam requested review from a team as code owners April 14, 2025 01:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (6ceb5ab) to head (df43eac).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          40       40           
  Lines        7004     7004           
=======================================
  Hits         3231     3231           
  Misses       3617     3617           
  Partials      156      156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekenstam
fix: add labels to docker image
df43eac 
Signed-off-by: Todd Ekenstam <[email protected]>
@tekenstam tekenstam merged commit d556581 into master Apr 14, 2025
7 checks passed
@tekenstam tekenstam deleted the workflow-permissions branch April 14, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tekenstam @codecov-commenter